fix(i18n): translation generator script ignoring JSONs #3106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: I18N "fix translation generator script ignoring JSONs"
Purpose of change
Describe the solution
removed
return
in first line onextract_all_from_json_file
which prevented all JSONs from getting extracted.Cataclysm-BN/lang/extract_json_strings.py
Lines 1374 to 1378 in 603db6e
before:
after:
Additional context
must've missed it in #2216. I should really make a github actions check for these kind of things but i'm too lazy...