Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): translation generator script ignoring JSONs #3106

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

scarf005
Copy link
Member

Summary

SUMMARY: I18N "fix translation generator script ignoring JSONs"

Purpose of change

Describe the solution

removed return in first line on extract_all_from_json_file which prevented all JSONs from getting extracted.

def extract_all_from_json_file(state, json_file):
return
"Extract translatable strings from every object in the specified JSON file."
state.current_source_file = json_file
log_verbose("Loading {}".format(json_file))

before:

$ wc po/cataclysm-bn.pot 
 257629  935222 7093763 po/cataclysm-bn.pot

after:

$ wc po/cataclysm-bn.pot
 48860 130276 895919 po/cataclysm-bn.pot

Additional context

must've missed it in #2216. I should really make a github actions check for these kind of things but i'm too lazy...

Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotfix

@Firestorm01X2 Firestorm01X2 merged commit 2d75e1b into cataclysmbnteam:upload Aug 31, 2023
@scarf005 scarf005 deleted the polib-rogue-return branch August 31, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transifex's strings disappear in large numbers.
3 participants