Code

refactor!: give items identity#2250

Code

Merged

scarf005 merged 217 commits intocataclysmbnteam:uploadcataclysmbnteam/Cataclysm-BN:uploadfrom joveeater:spring-refactorjoveeater/Cataclysm-BN:spring-refactorCopy head branch name to clipboardNov 4, 2023

+17,569-20,573

Commits

Commits on Jan 9, 2023

• Temp commit, now with compiling

  joveeater

  committed
  a12b47e

Commits on Feb 23, 2023

• More refactoring

  joveeater

  committed
  ad0ef91

Commits on Mar 10, 2023

• vehicles fix

  joveeater

  committed
  454ca13

Commits on Mar 20, 2023

• More bugfixes and the start of the test suite

  joveeater

  committed
  24b3ddd

Commits on Mar 29, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  16e53ef

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  2380410

Commits on Mar 30, 2023

• More bugfixes

  joveeater

  committed
  944cc0f

• More bugfixes

  joveeater

  committed
  a2b39d7

Commits on Apr 4, 2023

• Beginning of better types

  joveeater

  committed
  d60311c

Commits on Apr 7, 2023

• More new stuff, no compiling

  joveeater

  committed
  6b70aa5

Commits on Apr 10, 2023

• More moving to smart pointers

  joveeater

  committed
  7510577

• Bit more

  joveeater

  committed
  713af91

Commits on Apr 23, 2023

• More more more

  joveeater

  committed
  0da8198

Commits on Apr 25, 2023

• MOAR

  joveeater

  committed
  1110027

• More

  joveeater

  committed
  5d5897a

Commits on Apr 27, 2023

• even more

  joveeater

  committed
  6bcf8eb

• style: typo item_spawn -> item::spawn

  scarf005

  committed
  60c2393

• style: remove unnecessary std::move, use -> for activity

  Show description for 50518b2
  

  scarf005

  and

  joveeater

  committed
  50518b2

• fix: legacy null item reference

  Show description for 3553401
  

  scarf005

  and

  joveeater

  committed
  3553401

• docs: return type of reduce_charges

  scarf005

  committed
  0b12953

• style: astyle

  scarf005

  committed
  18112e1

• Merge pull request #1 from scarf005/copy-elision

  Show description for bcfe831
  joveeater

  authored
  bcfe831

Commits on May 5, 2023

• Now with compiling

  joveeater

  committed
  767c545

• More fixes

  joveeater

  committed
  189100b

Commits on May 6, 2023

• More fixes

  joveeater

  committed
  0209ed3

Commits on May 7, 2023

• Pre-merge commit, fairly stable now

  joveeater

  committed
  6d6a28f

• Round out interfaces

  joveeater

  committed
  4bd3a36

• All merged up

  joveeater

  committed
  c82307f

• Better vehicles and cleanup

  joveeater

  committed
  8c1c36a

• Remove traces and better destruction

  joveeater

  committed
  cd3aa3d

• Attempt to appease gcc with vectors

  joveeater

  committed
  c5ea05a

• Pretty sure this wasn't me but ok

  joveeater

  committed
  4b624a5

• ty clang tidy

  joveeater

  committed
  b9c775c

• Oh yeah sounds exist

  joveeater

  committed
  a40f45f

Commits on May 8, 2023

• bug fix

  joveeater

  committed
  f0b724c

• More merging

  joveeater

  committed
  74a2366

• Remove unused overmap constructors as they fail on some compilers

  joveeater

  committed
  7138c39

• Backwards compat

  joveeater

  committed
  0fe91b6

Commits on May 9, 2023

• Test suite compiles now

  joveeater

  committed
  23d1af1

Commits on May 15, 2023

• MOAR

  joveeater

  committed
  1567f4a

Commits on May 16, 2023

• More more more

  joveeater

  committed
  2225190

Commits on May 18, 2023

• Test suite passes

  joveeater

  committed
  e9f6c96

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  075d984

• Bad move

  joveeater

  committed
  0a196b6

• Fix missing super character constructors

  joveeater

  committed
  9514ef2

• Update init.cpp

  joveeater

  authored
  0e55826

• Update src/init.cpp

  Show description for 5490d6c
  

  joveeater

  and

  github-actions[bot]

  authored
  5490d6c

• Update src/init.cpp

  Show description for a3018d2
  

  joveeater

  and

  github-actions[bot]

  authored
  a3018d2

• Update init.cpp

  joveeater

  authored
  a1d4fdc

• Merge remote-tracking branch 'upstream/deferred-loading-ub' into spring-refactor

  joveeater

  committed
  f6fef39

Commits on May 19, 2023

• Remove unused stuff

  joveeater

  committed
  94efd3b

• And the missed use

  joveeater

  committed
  a1a6935

• Remove execinfo.h

  joveeater

  committed
  23c81f8

• Bugs

  joveeater

  committed
  c320530

• Fix map rotation

  joveeater

  committed
  4c6c5f2

• Fix failed wrecks

  joveeater

  committed
  d6f27b0

Commits on May 20, 2023

• More bugfixes

  joveeater

  committed
  582bf36

• Various bugs

  joveeater

  committed
  964b03b

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  5cf4e29

• More bugfixes

  joveeater

  committed
  3b1678f

• Fix disassembly

  joveeater

  committed
  312d122

Commits on May 21, 2023

• Fix dead removals

  joveeater

  committed
  ae159f1

• Back to late delete for now

  joveeater

  committed
  d42f9c5

• Missing property in constructor

  joveeater

  committed
  7775c98

• Activity fix

  joveeater

  committed
  4ed4d17

• More safety

  joveeater

  committed
  a05a51c

Commits on May 22, 2023

• style: format with code blocks

  scarf005

  committed
  fe65d83

• ups

  joveeater

  committed
  e2708b5

• Merge branch 'upload' into spring-refactor

  joveeater

  authored
  d2017f1

• Update crafting.cpp

  joveeater

  authored
  d7ce52f

• More fixes

  joveeater

  committed
  72dcc85

Commits on May 23, 2023

• More fixes

  joveeater

  committed
  a57239f

• Forgot to add a file

  joveeater

  committed
  b319e78

• Fix rotation offsets

  joveeater

  committed
  3e5ccaa

Commits on May 24, 2023

• Merge pull request #3 from scarf005/game-objects-docs

  Show description for 6fcf9f8
  joveeater

  authored
  6fcf9f8

• Appease gcc

  joveeater

  committed
  64bccc0

• Fixup android

  joveeater

  committed
  f856c69

• minor fixes

  joveeater

  committed
  7b8782f

Commits on May 25, 2023

• weapon charges fix

  joveeater

  committed
  eb44b19

Commits on May 26, 2023

• Fix monsters

  joveeater

  committed
  bddeec4

• Remove old rotation offsets

  joveeater

  committed
  fe9fe2f

• Fixes

  joveeater

  committed
  fc8daca

Commits on Jun 3, 2023

• minor safety, needs investigating

  joveeater

  committed
  d222b27

Commits on Jun 20, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  3292b58

Commits on Jul 14, 2023

• Merge branch 'upload' into spring-refactor, not done yet

  joveeater

  committed
  6689a63

Commits on Jul 15, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  cbb5bfd

Commits on Jul 18, 2023

• Fixes

  joveeater

  committed
  c107a27

Commits on Jul 19, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  7fd408d

• cleanup

  joveeater

  committed
  cc3137b

• pch fix and more cleanup

  joveeater

  committed
  daaffe1

Commits on Jul 20, 2023

• Merge branch 'upload' into spring-refactor

  scarf005

  authored
  10d1eeb

• Merge branch 'upload' into spring-refactor

  joveeater

  authored
  1dc2409

Commits on Jul 21, 2023

• merge

  joveeater

  committed
  867f96e

• Fix msvc

  joveeater

  committed
  152c389

Commits on Jul 23, 2023

• Fix spacing, remove unused includes

  olanti-p

  committed
  b26ea16

• Remove npc.h include from locations.h

  olanti-p

  committed
  a4e599f

• Remove leftovers from item_location

  olanti-p

  committed
  fc35e9a

• Remove old commented code

  olanti-p

  committed
  b5c73b7

• Remove player_activity.h from json.h

  olanti-p

  committed
  2d07409

• Split off activity_ptr into its own header

  olanti-p

  committed
  97054bb

• Fix typos

  olanti-p

  committed
  8bf8a5d

• Remove commented out or dead code

  olanti-p

  committed
  cf2510f

• Fix tidy warnings

  olanti-p

  committed
  8edf510

Commits on Jul 24, 2023

• Remove colony from update-pch.sh

  joveeater

  committed
  1e92947

• Merge pull request #4 from olanti-p/item-identity-23-07-2023

  Show description for 2f1bc14
  joveeater

  authored
  2f1bc14

• Merge remote-tracking branch 'origin/spring-refactor' into spring-refactor

  joveeater

  committed
  c2f88d3

• Hopefully this fixes the compile

  joveeater

  committed
  fddf2c5

Commits on Jul 25, 2023

• build fixes

  joveeater

  committed
  945a5fe

• Wrap long comments

  olanti-p

  committed
  1c9190d

• Fix typo

  olanti-p

  committed
  1ada61e

• Delete submodule

  olanti-p

  committed
  29acbc7

• Alternative build fix

  olanti-p

  committed
  1d0205f

• Fix dereferencing nullptr

  olanti-p

  committed
  8118233

• Remove extra space

  olanti-p

  committed
  05249cf

• Remove dead code

  olanti-p

  committed
  3e7373d

• Update src/detached_ptr.cpp

  Show description for 277c068
  

  joveeater

  and

  olanti-p

  authored
  277c068

• Update src/activity_actor.cpp

  Show description for 1f3dbe1
  

  joveeater

  and

  olanti-p

  authored
  1f3dbe1

• Update src/active_tile_data.cpp

  Show description for 000c5a0
  

  joveeater

  and

  olanti-p

  authored
  000c5a0

• Update src/handle_liquid.h

  Show description for afc06ac
  

  joveeater

  and

  olanti-p

  authored
  afc06ac

• Merge pull request #5 from olanti-p/item-identity-25-07-2023

  Show description for cb6ee3a
  joveeater

  authored
  cb6ee3a

• Update src/active_tile_data.cpp

  Show description for 82fbdab
  

  joveeater

  and

  github-actions[bot]

  authored
  82fbdab

• Fix takeoff deleting items

  joveeater

  committed
  b1075e7

• Fixes

  joveeater

  committed
  f76b178

Commits on Jul 26, 2023

• Liquid fix

  joveeater

  committed
  1f67b88

• Fix book crash

  joveeater

  committed
  a1e2bdd

• fix holsters

  joveeater

  committed
  7c0f646

Commits on Aug 10, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  ba4e860

• missed a spot

  joveeater

  committed
  91d2a78

Commits on Aug 16, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  360d121

Commits on Aug 29, 2023

• Merge remote-tracking branch 'upstream/upload' into spring-refactor

  scarf005

  committed
  5c371ed

• fix: make it compile

  scarf005

  committed
  8b574d4

Commits on Sep 11, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  0f04a09

• Merge branch 'spring-lua' into spring-refactor

  joveeater

  committed
  1e4f856

Commits on Sep 13, 2023

• Mess with lua iterators

  joveeater

  committed
  b06506d

Commits on Sep 23, 2023

• Merge remote-tracking branch 'upstream/upload' into spring-refactor

  scarf005

  committed
  2d1b37f

• Fixes

  joveeater

  committed
  09d3f4d

• Merge branch 'spring-refactor' into spring-0.4

  scarf005

  committed
  5531a5a

• fix: iexamine_elevator

  scarf005

  committed
  3a344ae

• fix: vehicle_part.h headers

  scarf005

  committed
  6fc592a

• fix: salvage by weight PR

  scarf005

  committed
  7d94ff7

• docs: game objects

  scarf005

  committed
  6d85c7a

• fix: salvage test

  scarf005

  committed
  0aee3c8

• Merge remote-tracking branch 'upstream/upload' into spring-0.4

  scarf005

  committed
  a3b3b47

• Merge pull request #7 from scarf005/spring-0.4

  Show description for d1d29c4
  joveeater

  authored
  d1d29c4

• style(autofix.ci): automated formatting

  autofix-ci[bot]

  authored
  f87a168

Commits on Sep 26, 2023

• submap rotate fixes

  joveeater

  committed
  e6eb11a

• Merge remote-tracking branch 'origin/spring-refactor' into spring-refactor

  joveeater

  committed
  e5110a6

Commits on Sep 27, 2023

• Shouldn't use uint

  joveeater

  committed
  e9a4cc5

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  bee0ad4

• And the rest

  joveeater

  committed
  f6d0256

Commits on Sep 28, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  59afa89

Commits on Sep 29, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  c25aa04

Commits on Sep 30, 2023

• Fix destroyed things being processed

  joveeater

  committed
  30cd47a

• Fix armor relayering

  joveeater

  committed
  9dfd4c8

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  76b1b4f

Commits on Oct 6, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  e519498

Commits on Oct 7, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  e0dc0bb

Commits on Oct 8, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  0b4b6a5

• fix gcc

  joveeater

  committed
  b360544

• style(autofix.ci): automated formatting

  autofix-ci[bot]

  authored
  c3fc753

• Fix filthy clothes

  joveeater

  committed
  edbf095

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  283f7b4

• Fix butchering

  joveeater

  committed
  6ca5680

• Random iterator safety fixes

  joveeater

  committed
  c0b956b

• refactor: trailing return goes brrrrr

  scarf005

  committed
  9ef4863

• refactor: apply clang-tidy suggestions

  scarf005

  committed
  5a173ee

• perf: remove obsoleted colony tests

  scarf005

  committed
  afe72e5

• perf: apply all clang-tidy performance fixes

  scarf005

  committed
  4e3bb46

• perf: use emplace_back

  scarf005

  committed
  113373c

• fix: position loopback segfaulting

  scarf005

  committed
  b27bd0a

• fix: keep location info on attempt_detach

  scarf005

  committed
  a75d782

• perf: remove flag usage for temperature display

  scarf005

  committed
  56d4229

• feat: give morale bonus for items EATEN_COLD

  scarf005

  committed
  67c0dfc

• Better position through attempt_detach

  joveeater

  committed
  b6725c2

• Merge pull request #11 from scarf005/clang-tidy-perf

  Show description for d2069d7
  joveeater

  authored
  d2069d7

• Update game_object.cpp

  joveeater

  authored
  6d170bc

• Update rot.cpp

  joveeater

  authored
  f94b7f1

• Merge pull request #12 from scarf005/fridges-are-cool

  Show description for 8144c81
  joveeater

  authored
  8144c81

• style(autofix.ci): automated formatting

  autofix-ci[bot]

  authored
  bfec42c

• Fix things rotting away

  joveeater

  committed
  02fab74

Commits on Oct 9, 2023

• Fix null cache references being moved badly

  joveeater

  committed
  9f75cca

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  9114851

• style(autofix.ci): automated formatting

  autofix-ci[bot]

  authored
  791acff

Commits on Oct 10, 2023

• Fix ub when active item list is empty

  joveeater

  committed
  c524884

Commits on Oct 11, 2023

• Prevents possible use after free in sounds

  joveeater

  committed
  c1a4e8a

• Merge branch 'sound-ub' into spring-refactor

  joveeater

  committed
  d84aa0a

Commits on Oct 15, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  a05cd40

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  9548bbb

Commits on Oct 17, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  965c201

• Appease windows compilers noexcept

  joveeater

  committed
  fdcac04

Commits on Oct 18, 2023

• Bunch of cleanup

  joveeater

  committed
  fc5f888

Commits on Oct 25, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  d00cbc9

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  8a36c8b

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  484b43b

• Proper move for lambda arg/return

  joveeater

  committed
  adc87f9

• style(autofix.ci): automated formatting

  autofix-ci[bot]

  authored
  f24486e

Commits on Oct 30, 2023

• Merge branch 'upload' into spring-refactor

  joveeater

  committed
  38c027f

• Merge remote-tracking branch 'origin/spring-refactor' into spring-refactor

  joveeater

  committed
  8bc16fb

Commits on Nov 2, 2023

• tidy

  joveeater

  committed
  e2e7884

• style(autofix.ci): automated formatting

  autofix-ci[bot]

  authored
  09fc616

• Merge remote-tracking branch 'cbn/upload' into spring-refactor

  olanti-p

  committed
  e80a4bc

• Fix or silence misc lints

  olanti-p

  committed
  26e44a4

• Fix accidental copy

  olanti-p

  committed
  c73e1c4

• Use somewhat safer deallocation on return

  olanti-p

  committed
  27df241

• Fix readability-inconsistent-declaration-parameter-name

  olanti-p

  committed
  c08c1f6

• Delete doc/GAME_OBJECT.md

  Show description for 3577fe1
  olanti-p

  committed
  3577fe1

• Use id as debug name to avoid it being translated

  olanti-p

  committed
  13a0587

• Fix nullptr access

  olanti-p

  committed
  0df5689

• Add blocks in switch cases

  olanti-p

  committed
  80cbc96

Commits on Nov 3, 2023

• Silence false positive use-after-move

  olanti-p

  committed
  14a353d

• Reorder some code to avoid use-after-move

  olanti-p

  committed
  6bd1991

• Reorder some code to avoid bugprone-if-assignment

  olanti-p

  committed
  3517cfa

• Fix moving of references

  olanti-p

  committed
  b72697c

• Remove noop detached_ptr<item>::release() calls

  olanti-p

  committed
  c78faaf

• Fix legit (?) cases of use-after-move

  olanti-p

  committed
  6d79737

• Fix crash in inventory dumping

  joveeater

  committed
  bd65e2a

• Fix bug in spells

  joveeater

  committed
  e6a7268