Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize string_formatter for std::string_view #2232

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Modernize string_formatter for std::string_view #2232

merged 1 commit into from
Dec 12, 2022

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented Dec 11, 2022 •
edited
Loading

Summary

SUMMARY: Infrastructure "Modernize string_formatter for std::string_view"

Purpose of change

C++17 is here, it's time to recognize some C++17 features

Describe the solution

Cherry-picked from #2216.

Make string_formatter accept std::string_view

Describe alternatives you've considered

Copying std::strings

Testing

Wrote some test cases for this

@github-actions github-actions bot added src changes related to source code. tests changes related to tests labels Dec 11, 2022
@Coolthulhu Coolthulhu self-assigned this Dec 11, 2022
@Coolthulhu Coolthulhu merged commit 8b34ed1 into cataclysmbnteam:upload Dec 12, 2022
@olanti-p olanti-p deleted the modernize-string-format branch December 17, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Coolthulhu Coolthulhu

Labels
src changes related to source code. tests changes related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olanti-p @Coolthulhu