Merge pull request #24 from cat-in-136/fix-like-btn-wrong-position

fix bug where Like buttons are placed at wrong position on notes in issues #23
cat-in-136 · Mar 16, 2019 · 2c2eb57 · 2c2eb57
2 parents a915acd + 316c01d
commit 2c2eb57
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,16 +5,16 @@ cache:
   - redmine/vendor/bundle
 matrix:
   include:
+  - rvm: 2.6.1
+    env: REDMINE_VERSION=4.0.2
   - rvm: 2.5.3
-    env: REDMINE_VERSION=4.0.0
-#  - rvm: 2.6.0-rc2
-#    env: REDMINE_VERSION=3.4.7
+    env: REDMINE_VERSION=4.0.2
   - rvm: 2.5.3
-    env: REDMINE_VERSION=3.4.7
+    env: REDMINE_VERSION=3.4.9
   - rvm: 2.4.5
-    env: REDMINE_VERSION=3.4.7
+    env: REDMINE_VERSION=3.4.9
   - rvm: 2.3.8
-    env: REDMINE_VERSION=3.4.7
+    env: REDMINE_VERSION=3.4.9
 before_install: bash -x bin/travisci_before_install.sh
 before_script: bash -x bin/travisci_before_script.sh
 script: bash -x bin/travisci_exec_test.sh

diff --git a/assets/javascripts/transplant_heart_link_with_counter.js b/assets/javascripts/transplant_heart_link_with_counter.js
@@ -17,8 +17,10 @@ $(function() {
     let heartable_subject = getHeartableSubject(link);
     let num_insert = 0;
 
+    console.debug({heartable_subject, link});
+
     if (num_insert === 0) {
-      let note_subject = heartable_subject.replace(/^[-a-z0-9]+-/, "note-");
+      let note_subject = heartable_subject.replace(/^[-a-z0-9]+-/, "change-");
       num_insert += $(link).prependTo($("#" + note_subject + " .journal-actions")).length;
     }
     if (num_insert === 0) {