Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update rbs to 3.0 #662

Merged
merged 3 commits into from
Jan 8, 2025
Merged

deps: Update rbs to 3.0 #662

merged 3 commits into from
Jan 8, 2025

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented May 15, 2023

Now solargraph depends on RBS-2.x. So we can't use Solargraph and the latest RBS. So this updates the dependency to RBS 3.0. What do you think?

tk0miya added 2 commits May 15, 2023 11:21
@tk0miya
deps: Update rbs to 3.0
eb505c3
@tk0miya
spec: Use fileutils for testing Solargraph::Rbs::StdlibMap
e39bf76 
The "set" has been merged into the Ruby Core and RBS has been drop
support since v3.0.  So current spec implementation will not work with
RBS-3.x.
@D-system
Copy link

D-system commented Feb 5, 2024

@castwide any reservation to update to rbs 3.0?

qbantek
qbantek approved these changes Jul 3, 2024
View reviewed changes
Copy link

@qbantek qbantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Earlopain Earlopain mentioned this pull request Jul 12, 2024
Closed
@toby-brilliant toby-brilliant mentioned this pull request Jul 18, 2024
Closed
@lekemula
Copy link
Contributor

lekemula commented Oct 3, 2024

Hey @tk0miya / @castwide, is there anything holding this from being shipped?

This is kinda blocking merging solargraph-rspec into Gitlab's codebase which would serve as a great source of feedback for improving it further.

https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157114#note_1982725864

Thanks!

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 3, 2024

No problem from my side. I'm also waiting to merge this to master.

@jollopre
Copy link

jollopre commented Jan 3, 2025

Hey there, any updates on this? One of the issues I'm facing with existing latest release is when hovering to see documentation of ruby built-in classes. For instance, Thread::Queue#pop from ruby 3.2 had a nice addition with keywords like timeout and I was being tricked because the version of the documentation that I got installed for rbs was 2.8.4.

Info about my rbs gems installed:

gem info rbs

*** LOCAL GEMS ***

rbs (3.8.0, 2.8.4)
    Author: Soutaro Matsumoto
    Homepage: https://github.com/ruby/rbs
    Licenses: BSD-2-Clause, Ruby
    Installed at (3.8.0): /usr/local/lib/ruby/gems/3.4.0
                 (2.8.4): /usr/local/bundle

    Type signature for Ruby.

Screenshot of the hover functionality which uses rbs 2.8.4 for the documentation of Thread::Queue#pop:
Screenshot 2025-01-03 at 08 13 32

@castwide
Copy link
Owner

castwide commented Jan 8, 2025

LGTM :shipit:

@castwide castwide merged commit 74fece0 into castwide:master Jan 8, 2025
@tk0miya tk0miya deleted the update_rbs branch January 8, 2025 11:50
@tk0miya tk0miya restored the update_rbs branch January 10, 2025 06:50
@tk0miya tk0miya deleted the update_rbs branch January 20, 2025 06:52
@tk0miya tk0miya restored the update_rbs branch January 20, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbantek qbantek qbantek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tk0miya @D-system @lekemula @jollopre @castwide @qbantek