DE-6967: Interstitial player component #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingerartur
force-pushed
the
feat/DE-6967-interstitial
branch
2 times, most recently
from
16a5881 to
2a320b9
Compare
thasso
approved these changes
Apr 8, 2024
* FEATURES Add option to configure visibility of player controls and to fully hide them. Make base theme configurable: audio controls, full screen button, track controls. Add support for UI cues. Add support for companion component above the bottom bar of player controls. * FIXES Fix rounding of video duration. Now all values with remainder 0.8 and higher are rounded UP instead of down, to produce a more accurate value. * REFACTOR Remove unnecessary private annotations. Cleanup: detach listeners from PRESTO instance. Allow presto instance to be null. * APP Move index.html to root folder. Add mux.js to support HLS playback. * TOOLING Add prepack script, this way it is easy to pack TGZ NPM packages for local use. The ESLint rule is getting miss-reported `@typescript-eslint/no-unsafe-assignment`, I'm not sure why, but let's just ignore it for now.
fingerartur
force-pushed
the
feat/DE-6967-interstitial
branch
from
33f451a to
9d9410f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm adding the a Player component for HLS interstitial streams.
So far it is a dedicated component and it has a custom Player surface and Player (state manager).
There's still one thing missing - I have to release a latest beta of PRESTOplay and add it as dependency.