This repository has been archived by the owner on Apr 2, 2022. It is now read-only.
Implement downloads #201
Open
Implement downloads #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous event didn't trigger on click.
cassidyjames
suggested changes
Oct 18, 2019
src/Widgets/DownloadsButton.vala
Outdated
| * | ||
| * Authored by: Adrian Cochrane <[email protected]> | ||
| */ | ||
| namespace Ephemeral { |
There was a problem hiding this comment.
I typically avoid the extra indentation level and just namespace the class itself, i.e. Ephemeral.DownloadsButton. I think I'd like to do that here as well for consistency with the rest of the codebase.
There was a problem hiding this comment.
I differed for the sake of two helper classes, but I can make that adjustment.
|
It looks like a lot of the margins and whatnot didn't get carried over from the prototype branch as well. I can work on cleaning those up, but I just thought I'd share here for posterity. Prototype
This branch
|
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
Co-Authored-By: Cassidy James Blaede <[email protected]>
|
I've gone over your feedback and incorporated it into my pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
It matches your mockup, except it uses a ListBox for better keyboard input and nicer layout upon removing a download. And as requested it shows a Toast once the download has been completed.