Add list-transactions subcommand
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
reviewed
Jan 23, 2025
lib/json_rpc/call.rs
Outdated
| let client = CLIENT.get_or_init(Client::new); | ||
| let client = CLIENT.get_or_init(|| { | ||
| Client::builder() | ||
| .timeout(REQUEST_TIMEOUT) |
There was a problem hiding this comment.
timeout should probably be an optional argument for any of the commands which defaults to REQUEST_TIMEOUT.
We don't have to do that in this PR IMHO
zajko
approved these changes
Jan 23, 2025
wojcik91
merged commit 7450440
into
casper-ecosystem:feat-track-node-2.0
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
node_addressparsing to avoid opaque errors and add a request timeout.Closes #225