Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Http client - avoid cloning #463

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

crodas
Copy link
Contributor

@crodas crodas commented Nov 19, 2024

Description

Store the HTTP response as a string instead of parsing it as a json::Value and cloning it several times.

This improvement has been found while working on adding WebSocket support.

Suggested CHANGELOG Updates

CHANGED

  • Minor improvement: avoid cloning HTTP responses; instead, store them as a string and use Serde's ability to parse strings.

Store the HTTP response as string instead of parsing as a json::Value and
cloning it several times.
@thesimplekid thesimplekid merged commit 5dd196d into cashubtc:main Nov 19, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants