Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: precommit yml #451

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

thesimplekid
Copy link
Collaborator

No description provided.

@vnprc
Copy link
Contributor

vnprc commented Nov 15, 2024

I have successfully tested a commit on this branch.

On main:

evan@evans-MacBook-Pro cdk % git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
evan@evans-MacBook-Pro cdk % nix develop
git-hooks.nix: updating /Users/evan/work/cdk repo
/Users/evan/work/cdk/.pre-commit-config.yaml
commit-msg uninstalled
pre-commit uninstalled
pre-commit installed at .git/hooks/commit-msg
pre-commit installed at .git/hooks/pre-commit
evans-MacBook-Pro:cdk evan$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .pre-commit-config.yaml

no changes added to commit (use "git add" and/or "git commit -a")

This is undesirable because the diff for .pre-commit-config.yaml causes the precommit hooks to block my commits. Very meta.

On this branch it is fixed:

evan@evans-MacBook-Pro cdk % git status
On branch pr-451
nothing to commit, working tree clean
evan@evans-MacBook-Pro cdk % nix develop
evans-MacBook-Pro:cdk evan$ git status
On branch pr-451
nothing to commit, working tree clean

I can now commit without issue.

@thesimplekid thesimplekid merged commit 2231a54 into cashubtc:main Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants