Upgrade to Kotlin 1.9.20 #1158
Upgrade to Kotlin 1.9.20 #1158
Conversation
error: implicit conversion from 'long long' to 'double' changes
value from 9223372036854775807 to 9223372036854775808
[-Werror,-Wimplicit-const-int-float-conversion]
else if (d > INT64_MAX)
~ ^~~~~~~~~
swankjesse
force-pushed
the
jwilson.1101.kt1920
branch
from
2708c7e
to
0cf55d9
Compare
| @@ -202,7 +202,6 @@ public abstract interface class app/cash/zipline/ZiplineFunction { | |||
|
|
|||
| public final class app/cash/zipline/ZiplineManifest { | |||
| public static final field Companion Lapp/cash/zipline/ZiplineManifest$Companion; | |||
| public synthetic fun <init> (ILapp/cash/zipline/ZiplineManifest$Unsigned;Ljava/util/Map;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/util/Map;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V | |||
There was a problem hiding this comment.
Unclear to me what the binary-compatibility consequences are of dropping these synthetic constructors. It would be pretty horrible if code compiled for 1.9.10 crashed when deserializing these!
But I don’t think I have many choices here; this is a deep implementation detail of kotlinx.serialization.
There was a problem hiding this comment.
Phew, looks like it’s safe!
Kotlin/kotlinx.serialization#2209
zipline-testing/src/hostMain/kotlin/app/cash/zipline/testing/IoTestingCommon.kt
Show resolved
Hide resolved
| @@ -78,6 +78,8 @@ | |||
| #define CONFIG_STACK_CHECK | |||
| #endif | |||
|
|
|||
| /* Zipline-patched for https://github.com/bellard/quickjs/pull/196 */ | |||
| static double const INT64_MAX_PLUS_ONE_AS_DOUBLE = 9223372036854775808.0; | |||
There was a problem hiding this comment.
Details on this one:
bellard/quickjs#196
gradle/libs.versions.toml
Outdated
| @@ -1,10 +1,10 @@ | |||
| [versions] | |||
| androidx-compose = "1.5.4" | |||
| androidx-compose-compiler = "1.5.2" | |||
| androidx-compose-compiler = "1.5.3" | |||
There was a problem hiding this comment.
I assume we're blocked waiting for 1.5.4 here?
There was a problem hiding this comment.
Unsure. This is only needed for the world clock sample.
There was a problem hiding this comment.
> Task :world-clock:android:compileDebugKotlin FAILED
e: This version (1.5.3) of the Compose Compiler requires Kotlin version 1.9.10 but you appear to be using Kotlin version 1.9.20 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or `suppressKotlinVersionCompatibilityCheck` but don't say I didn't warn you!).
There was a problem hiding this comment.
Since it’s just a sample, I’m gonna use the pre-release version.
25bb9cd
No description provided.