Replace [en|de]codeNullableSerializableElement with nullable
#1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
commented
Oct 17, 2023
| @@ -234,6 +234,8 @@ internal class BridgedInterface( | |||
| ) | |||
| putValueArgument(1, parameterList) | |||
| } | |||
| ziplineApis.nullableSerializer // TODO Invoke this on [contextualSerializerExpression] if the [type] is nullable. | |||
There was a problem hiding this comment.
@JakeWharton / @swankjesse Any ideas on how to do this? I've been searching for some API that'd take an IrPropertySymbol with contextualSerializerExpression as a receiver, but I'm a bit lost. I failed at finding some prior art of this being done within Zipline and online.
There was a problem hiding this comment.
Here's how the built-in kotlinx.serialization plugin does it: https://github.com/JetBrains/kotlin/blob/ec79d8cd2711e78883c77f2e6c4ec377398aecb9/plugins/kotlinx-serialization/kotlinx-serialization.backend/src/org/jetbrains/kotlinx/serialization/compiler/backend/ir/BaseIrGenerator.kt#L359-L378
There was a problem hiding this comment.
Oh damn, that's perfect. Thanks!
veyndan
force-pushed
the
veyndan/2023-10-17/nullable
branch
from
8b5e4d9
to
eb88c2f
Compare
`encodeNullableSerializableElement` and `decodeNullableSerializableElement` are both experimental APIs, whereas `nullable` isn't.
veyndan
force-pushed
the
veyndan/2023-10-17/nullable
branch
from
eb88c2f
to
f90e7cf
Compare
JakeWharton
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodeNullableSerializableElementanddecodeNullableSerializableElementare both experimental APIs, whereasnullableisn't.