tslint -> Eslint #1848
Merged
tslint -> Eslint #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r3mariano curious what your thoughts are on this one so far. I ended up removing the tslint package completely, do you see any value in copying our |
I'd like the template (this) to include a default
This is good though. I think using eslint's defaults as a starter is enough. |
r3mariano
approved these changes
Oct 6, 2022
|
For sure, I'll track that in #1913 |
Some rules have been disabled as they either weren't handled by the old tslint config or tslint just wasn't configured before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tslint has been deprecated since 2019, furthermore it isn't seeing much further development (as of now the last release was mid-2020). With that in mind, this PR migrates misk-web to use eslint!