-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements #19
Open
khatchad
wants to merge
70
commits into
caseycas:master
Choose a base branch
from
ponder-lab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhancements #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khatchad
commented
Jul 30, 2019
•
edited
Loading
edited
- Add .gitignore.
- Remove invalid characters in SQL statements.
- Other fixes.
Postgresql doesn't like them and they can be used to find methods in the diff.
Postgresql doesn't like them and they can be used to find methods in the diff.
Use underscore instead. Otherwise, we may collide with other column names.
Case sensitive.
Already did it.
This reverts commit 614d99d.
Tests are now passing.
Add EOD.
Merge private changes to the public repo
Clean up.
This reverts commit 0b75a59.
Fix failing building by updating nltk version.
Add repos from other GH searches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.