Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enforcer EnableAcceptJsonRequest feature #119

Conversation

ali-shokoohi
Copy link
Contributor

@ali-shokoohi ali-shokoohi commented Oct 4, 2024

Fix: #111

Version of the "Casbin" module upgraded to 2.100 to access the "bleAcceptJsonRequest" feature then integrated this project with the new version of the "Casbin" then added new requested feature.

Changes:

  • Upgraded the version of the "Casbin" module
  • Integrated with the new version of the "Casbin" module
  • Changed the .proto file to add "EnableAcceptJsonRequest" field at calling NewEnforcer
  • Generated Go files from new changed the .proto file
  • Added "EnableAcceptJsonRequest" field to each "NewEncoder" test cases

Version of the "Casbin" module upgraded to 2.100 to access the "bleAcceptJsonRequest" feature then integrated this project with the new version of the "Casbin" then added new requested feature.

Changes:
- Upgraded the version of the "Casbin" module
- Integrated with the new version of the "Casbin" module
- Changed the .proto file to add "EnableAcceptJsonRequest" field at calling NewEnforcer
- Generated Go files from new changed the .proto file
- Added "EnableAcceptJsonRequest" field to each "NewEncoder" test cases
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ali Shokoohi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Oct 4, 2024

Coverage Status

coverage: 67.722% (-1.4%) from 69.072%
when pulling 72690dd on ali-shokoohi:feat/add-enforcer-EnableAcceptJsonRequest-feature
into 8d65648 on casbin:master.

@ali-shokoohi ali-shokoohi changed the title Solved: #111 feat: add enforcer EnableAcceptJsonRequest feature Oct 4, 2024
@ali-shokoohi ali-shokoohi reopened this Oct 4, 2024
@hsluoyz hsluoyz merged commit 8d7fda9 into casbin:master Oct 5, 2024
4 of 7 checks passed
Copy link

github-actions bot commented Oct 5, 2024

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hsluoyz
Copy link
Member

hsluoyz commented Oct 5, 2024

@ali-shokoohi can you also update the client according to this PR? https://github.com/casbin/casbin-go-client

@ali-shokoohi
Copy link
Contributor Author

@hsluoyz Hi. Of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enforcer EnableAcceptJsonRequest
4 participants