Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing persist/string_adapter.cpp to CMakeLists.txt #238

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: add missing persist/string_adapter.cpp to CMakeLists.txt #238

merged 1 commit into from
Nov 10, 2023

Conversation

COM8
Copy link
Contributor

@COM8 COM8 commented Nov 10, 2023

Description

Fixes casbin/persist/string_adapter.h not being able to include since linking will fail since persist/string_adapter.cpp is not included inside casbin/CMakeLists.txt.

@casbin-bot
Copy link
Member

@EmperorYP7 @sheny1xuan @cs1137195420 please review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Fabian Sauter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz hsluoyz changed the title fix: added missing persist/string_adapter.cpp fix: add missing persist/string_adapter.cpp to CMakeLists.txt Nov 10, 2023
@hsluoyz hsluoyz merged commit 4deab3b into casbin:master Nov 10, 2023
13 of 14 checks passed
Copy link

🎉 This PR is included in version 1.54.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants