Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

162 add docstrings to astrohack tests #166

Merged
merged 7 commits into from
Oct 5, 2023
Merged

162 add docstrings to astrohack tests #166

merged 7 commits into from
Oct 5, 2023

Conversation

jrhosk
Copy link
Collaborator

@jrhosk jrhosk commented Oct 4, 2023

Fixed some of the previously written test to work as they should and added the remaining docstrings.

@jrhosk jrhosk linked an issue Oct 4, 2023 that may be closed by this pull request
Add docstrings to astrohack tests #162
Closed
@jrhosk jrhosk requested a review from smcastro October 4, 2023 15:54
@jrhosk jrhosk added the documentation Improvements or additions to documentation label Oct 4, 2023
@jrhosk jrhosk self-assigned this Oct 4, 2023
smcastro
smcastro reviewed Oct 4, 2023
View reviewed changes
tests/unit/test_holog.py Outdated Show resolved Hide resolved
smcastro
smcastro reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@smcastro smcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have that small comment on test_holog.py. All look good to me. Thanks

@jrhosk
Update test_holog.py
7ffc795 
Fix typo mentioned by Sandra
@jrhosk jrhosk merged commit bb8fe61 into main Oct 5, 2023
4 checks passed
@jrhosk jrhosk deleted the 162-add-docstrings-to-astrohack-tests branch October 5, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcastro smcastro smcastro left review comments

Assignees

@jrhosk jrhosk

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docstrings to astrohack tests
2 participants
@jrhosk @smcastro