Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 locit solver for antenna positions #140

Merged
merged 49 commits into from
Sep 7, 2023

Conversation

vsmagalhaes
Copy link
Collaborator

LOCIT prototype.
This prototype is capable of fitting the delays to produce antenna position corrections.
Some tests have been done where it achieves similar (but not equal) results to AIPS and is able to recover simulated antenna position shifts.
It still needs several improvements which will be added as issues.

Victor de Souza Magalhaes and others added 30 commits August 31, 2023 15:08
…in dict that contain info on their name are ignored
…a and scipy fits.

scipy and linear algebra agree for up to 5 or 6 decimal places!
… Now the polarization scheme is inferred from the telescope being used.
Victor de Souza Magalhaes and others added 17 commits August 31, 2023 15:08
…is is the first step in making locit capable of combining DDIs in the fit, plotting routines not yet updated
…ing locit capable of combining DDIs in the fit, plotting routines not yet updated
…s is the third step in making locit capable of combining DDIs in the fit, plotting routines not yet updated
…utines not yet updated, error bars in linear algebra fit meaningless
plot_delays, which supports the two possible structures for the position mds
@vsmagalhaes vsmagalhaes added the Area:SciDev Science Feature development,validation, bugfix label Aug 31, 2023
@vsmagalhaes vsmagalhaes added this to the VLA Support milestone Aug 31, 2023
@vsmagalhaes vsmagalhaes linked an issue Aug 31, 2023 that may be closed by this pull request
@jrhosk
Copy link
Collaborator

jrhosk commented Sep 6, 2023

Perhaps we should make the default writing plots to disk as opposed to the notebook cell. As you can see below even with the test file we are running into memory issues and the cell actually truncates the output after the first 50 outputs.

image

A viewer could be built is needs be.

Anyways, I think this can be merged tomorrow. So far everything seems to work as I would naively expect.

@jrhosk jrhosk merged commit 3c51658 into main Sep 7, 2023
4 checks passed
@jrhosk jrhosk deleted the 28-locit-solver-for-antenna-positions branch September 7, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:SciDev Science Feature development,validation, bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOCIT : Solver for antenna positions
2 participants