Skip to content

Commit

Permalink
Pick a unique artifact filename per runner
Browse files Browse the repository at this point in the history
This avoids a clash upon upload.

Also remove the isolated build environment when building the wheel,
to ensure that we use Homebrew NumPy < 2.0 (and the one that is linked
to casacore).
  • Loading branch information
ludwigschwardt committed Jul 1, 2024
1 parent 9347b4b commit fa122fb
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: python3 -m venv venv --system-site-packages

- name: Install Python dependencies
run: venv/bin/pip install --upgrade pip wheel delocate pytest
run: venv/bin/pip install --upgrade pip six wheel delocate pytest

- name: Compile and install python-casacore
run: venv/bin/pip install .
Expand All @@ -51,12 +51,15 @@ jobs:
run: cd tests && ../venv/bin/pytest

- name: Make binary wheel
run: venv/bin/pip wheel -w dist .
# XXX Use Homebrew's numpy to be safe for now, especially since
# PyPI is now on numpy 2.0, which complicates matters
run: venv/bin/pip wheel -w dist --no-build-isolation .

- name: Delocate binary wheel
run: venv/bin/delocate-wheel -v dist/*.whl

- name: Publish macOS binary wheels
uses: actions/upload-artifact@v4
with:
name: wheel_${{ matrix.os }}
path: dist/*.whl

0 comments on commit fa122fb

Please sign in to comment.