Skip to content

Commit

Permalink
Use the system numpy in GitHub action
Browse files Browse the repository at this point in the history
Casacore will be compiled against Homebrew numpy 1.26.4, while the
virtual environment will cause python-casacore to pull in numpy 2.0.0
from PyPI. Those two won't play well together.

Reconsider when Homebrew ships with numpy 2.0.0. Even then, it doesn't
seem like a great idea to compile against one instance of numpy and
run against another.
  • Loading branch information
ludwigschwardt committed Jun 28, 2024
1 parent 6ed2c1b commit ed4f292
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ jobs:
brew install casacore
- name: make virtualenv
run: python3 -m venv venv
# XXX Use Homebrew's numpy to be safe for now, especially since
# PyPI is now on numpy 2.0, which complicates matters
run: python3 -m venv venv --system-site-packages

- name: Install Python dependencies
run: venv/bin/pip install --upgrade pip wheel delocate pytest
Expand Down

0 comments on commit ed4f292

Please sign in to comment.