Introduce inclusive naming check and update existing language #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
created as a draft until https://github.com/vmware-tanzu/carvel/pull/595 lands |
We are following the Inclusive Naming Initiative's guidance as that is what the CNCF supports.
aaronshurley
force-pushed
the
inclusive-naming
branch
from
bada2cd to
aa5c7bd
Compare
9 tasks
praveenrewar
approved these changes
Nov 21, 2022
| @@ -10777,7 +10777,7 @@ data: | |||
| require_client_certificate: true | |||
|
|
|||
|
|
|||
| # Manual 'whitebox' mode | |||
| # Manual 'open-box' mode | |||
There was a problem hiding this comment.
Maybe we should include the complete examples directory in the wokeignorefile? (As almost all the the config files are generated through some instructions and we don't have much control over it)
I am fine with this approach as well :)
There was a problem hiding this comment.
@praveenrewar Good question. I don't have a strong opinion on this. Since you're a primary maintainer of this repo, I'll leave it to you to decide on the long-term plan. I'm going to merge this PR as is. Thanks for the review!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are following the Inclusive Naming Initiative's guidance as that is what the CNCF supports.
What this PR does / why we need it:
This PR addresses https://github.com/vmware-tanzu/carvel/issues/594
Which issue(s) this PR fixes:
Fixes https://github.com/vmware-tanzu/carvel/issues/594
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: