Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module to github.com/vmware-tanzu/carvel-kapp #567

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Aug 1, 2022

What this PR does / why we need it:

Renames the Go module to match the github repository, github.com/vmware-tanzu/carvel-kapp

Which issue(s) this PR fixes:

Fixes #437

Does this PR introduce a user-facing change?

The kapp Go module is renamed to github.com/vmware-tanzu/carvel-kapp

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I think we should make an announcement in the public channel even before merging this PR so that someone using develop branch wouldn't be surprised 🤔

@aaronshurley
Copy link
Contributor

@praveenrewar anything blocking this merge? I agree that making some noise in slack is a good idea.

@100mik
Copy link
Contributor

100mik commented Aug 19, 2022

I believe it was just "getting the word out"
Not sure if that still is the case

@praveenrewar
Copy link
Member

Hey @aaronshurley! I was away last week, will get this moving now :)

@praveenrewar praveenrewar merged commit e7d9e9f into carvel-dev:develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename module from "github.com/k14s/kapp" to "github.com/vmware-tanzu/carvel-kapp"
5 participants