Add option --allow-change-package-name in the package installed update operation #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operation this option allows user to change the package name for the packageinstalled CR Signed-off-by: luwang <[email protected]>
| // If o.PackageName is provided by the user (via --package flag), verify that the package name in PackageInstall matches it. | ||
| // This will prevent the users from accidentally overwriting an installed package with another package content due to choosing a pre-existing name for the package isntall. | ||
| // Otherwise if o.PackageName is not provided, fill it from the installed package spec | ||
| if o.packageName != "" && updatedPkgInstall.Spec.PackageRef.RefName != o.packageName { | ||
| return nil, fmt.Errorf("Installed package '%s' is already associated with package '%s'", o.Name, updatedPkgInstall.Spec.PackageRef.RefName) | ||
| if !o.rename { |
There was a problem hiding this comment.
nit:
could you please reverse the if condition?
if o.rename {
updatedPkgInstall.Spec.PackageRef.RefName = o.packageName
} else {
if o.packageName != "" && updatedPkgInstall.Spec.PackageRef.RefName != o.packageName {
return nil, fmt.Errorf("Installed package '%s' is already associated with package '%s'", o.Name, updatedPkgInstall.Spec.PackageRef.RefName)
}
o.packageName = updatedPkgInstall.Spec.PackageRef.RefName
}
| @@ -195,6 +197,7 @@ func NewUpdateCmd(o *CreateOrUpdateOptions, flagsFactory cmdcore.FlagsFactory) * | |||
| cmd.Flags().StringVarP(&o.version, "version", "v", "", "Set package version") | |||
| cmd.Flags().StringVar(&o.valuesFile, "values-file", "", "The path to the configuration values file, optional") | |||
| cmd.Flags().BoolVar(&o.values, "values", true, "Add or keep values supplied to package install, optional") | |||
| cmd.Flags().BoolVar(&o.rename, "allow-change-package-name", false, "Allow to use different package name, optional") | |||
There was a problem hiding this comment.
please change the flag name to allow-package-name-change or rename-package ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option allow-change-package-name in the package installed update operation
this option allows user to change the package name for the packageinstalled CR
What this PR does / why we need it:
We need to change the package name for the installed package. However the current code blocks it .
Which issue(s) this PR fixes:
Fixes #1651
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: