Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in vendir docs #715

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix typo in vendir docs #715

merged 1 commit into from
Jan 11, 2024

Conversation

amananand20
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for carvel canceled.

Name Link
🔨 Latest commit c6cf68e
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/65a03903d38fa80008ccc7e4

@amananand20
Copy link
Contributor Author

resolves typo fixes to issue #681

@praveenrewar
Copy link
Member

@amananand20 Thanks for the PR. Could you please sign your commits to make the DCO check pass. (git commit -s ... can be used to sign your commits)

Signed-off-by: Aman Anand <[email protected]>
@amananand20
Copy link
Contributor Author

hey @praveenrewar , amended my commit and added sign.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@praveenrewar praveenrewar changed the title resolves: #681 Fix typo in vendir docs Jan 11, 2024
@praveenrewar praveenrewar merged commit a130f5c into carvel-dev:develop Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants