-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version the documentation for all tools #339
Conversation
We're hashing out the pros and cons of having the
Moving into "draft" until we work that out. |
7fd66b7
to
32bee62
Compare
@@ -0,0 +1,4 @@ | |||
{{ $latest := site.Params.latest }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might need to identify the multiple projects here.
Can you try changing this to something like:
{{ $latest-ytt := site.Params.ytt.version_latest }}
{{ $latest-imgpkg := site.Params.imgpkg.version_latest }}
/ytt/docs/ /ytt/docs/{{ $latest-ytt }}
/imgpkgdocs/ /ytt/docs/{{ $latest-ytt }}
d6292d1
to
c4bb3f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic!
Bonus points for providing the workflow hook that detects changes in "frozen" docs!! 👍🏻
There are multiple incompatible versions of yq
. The release-docs.sh
script fails with the version of yq
that wraps jq
.
Suggestions below to avoid any such problems by using ytt
to pluck values from a YAML.
Since the version drop down list is located at the top of the table of contents, it would be nice to keep that left sidebar fixed, and have it scroll independently from the documentation. There is an issue https://github.com/vmware-tanzu/carvel/issues/324, if we would like to prioritize that work. |
d2b54fd
to
6f6cfa6
Compare
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
This reverts commit 75a39a7.
Signed-off-by: Joao Pereira <[email protected]>
Signed-off-by: Joao Pereira <[email protected]>
Signed-off-by: Joao Pereira <[email protected]>
6f6cfa6
to
9c53777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- [@ytt:yaml module](../../../ytt/docs/latest/lang-ref-ytt.md#yaml) No newline at end of file | ||
- [@ytt:yaml module](../../../ytt/docs/latest/lang-ref-ytt.md#yaml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why git thinks these 2 lines are different 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pulling this together, @joaopapereira. It's not just another PR, it's the equivalent of sweeping up a whole section of the workshop and making it ship-shape. 🙏🏻
Implements: https://github.com/vmware-tanzu/carvel/tree/develop/proposals/carvel/001-maintain-documentation
In this PR:
Not included on this PR: