Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support libheif versions from 1.16.1 to 1.18.2 #97

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Support libheif versions from 1.16.1 to 1.18.2 #97

merged 2 commits into from
Aug 25, 2024

Conversation

homm
Copy link
Contributor

@homm homm commented Aug 16, 2024 •
edited
Loading

Fixes #96 #93 #43

Run:

$ make check_libheif_versions

@homm homm changed the title Support libheif versions from from 1.16.1 to 1.18.2 Support libheif versions from 1.16.1 to 1.18.2 Aug 16, 2024
@homm homm force-pushed the support-libheif-versions branch 2 times, most recently from 8c618c6 to 0f70c6a Compare August 16, 2024 15:23
@homm
Dockerfile improvements:
0afb773 
Fix docker image version
Exclude outdated pp37 & pp38
Include cp312 & pp310
Upgrade X265, LIBDE265 & LIBAOM to latest versions
Check actual libheif versions
@homm homm force-pushed the support-libheif-versions branch from 0f70c6a to 0afb773 Compare August 16, 2024 15:52
@homm
Copy link
Contributor Author

homm commented Aug 19, 2024

@ant32bit-carsales I also rebased #89 Read transformations upon this branch.
I’d like to raise a question about transferring ownership of this library again. For now it looks abandoned. While still it have a value for our product and we have resources to maintain it.

@homm
Copy link
Contributor Author

homm commented Aug 23, 2024

@ant32bit What do you think?

ant32bit-carsales
ant32bit-carsales approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@ant32bit-carsales ant32bit-carsales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built, ran and tested on M1 and Intel. It works well. Thanks.

@ant32bit-carsales ant32bit-carsales merged commit 7540fd1 into carsales:master Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant32bit-carsales ant32bit-carsales ant32bit-carsales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New release which works with current libheif
2 participants
@homm @ant32bit-carsales