-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand alt text in episode 2 #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ DANGER ❌This pull request has modified workflows that created output. Close this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I left a few small changes. Feel free to merge after resolving them!
Thanks for the review @svenvanderburg 🙌 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Auto-generated via {sandpaper} Source : e102f7f Branch : main Author : Toby Hodges <[email protected]> Time : 2024-07-30 08:42:21 +0000 Message : Merge pull request #510 from carpentries-incubator/alt-text-penguins Expand alt text in episode 2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Auto-generated via {sandpaper} Source : 63e38a2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-07-30 08:43:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : e102f7f Branch : main Author : Toby Hodges <[email protected]> Time : 2024-07-30 08:42:21 +0000 Message : Merge pull request #510 from carpentries-incubator/alt-text-penguins Expand alt text in episode 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One part of #429
Makes the alternative text descriptions for the two pair plots more descriptive of what the data shows. I also adjusted one of the other descriptions a little, and moved the metadata for the example of a bad training curve to join the others at the end of the file.