Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand alt text in episode 2 #510

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Expand alt text in episode 2 #510

merged 3 commits into from
Jul 30, 2024

Conversation

tobyhodges
Copy link
Member

One part of #429

Makes the alternative text descriptions for the two pair plots more descriptive of what the data shows. I also adjusted one of the other descriptions a little, and moved the metadata for the example of a bad training curve to join the others at the end of the file.

Copy link

github-actions bot commented Jul 23, 2024

❌ DANGER ❌

This pull request has modified workflows that created output. Close this now.

github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Copy link
Collaborator

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I left a few small changes. Feel free to merge after resolving them!

episodes/2-keras.Rmd Outdated Show resolved Hide resolved
episodes/2-keras.Rmd Outdated Show resolved Hide resolved
episodes/2-keras.Rmd Outdated Show resolved Hide resolved
episodes/2-keras.Rmd Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@tobyhodges
Copy link
Member Author

Thanks for the review @svenvanderburg 🙌

@tobyhodges tobyhodges merged commit e102f7f into main Jul 30, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : e102f7f
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-07-30 08:42:21 +0000
Message : Merge pull request #510 from carpentries-incubator/alt-text-penguins

Expand alt text in episode 2
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : 63e38a2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-30 08:43:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e102f7f
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-07-30 08:42:21 +0000
Message : Merge pull request #510 from carpentries-incubator/alt-text-penguins

Expand alt text in episode 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants