Add option for allowing the grouping of paths. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For routers that have variables in the path, the HistoGram instance can become huge. This can be both a memory problem and a problem for prometheus scrape times. This change adds an option to group the path in the prom metrics such that the matching route name is used instead of the request uri path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For routers that have variables in the path, the HistoGram
instance can become huge. This can be both a memory problem
and a problem for prometheus scrape times.
This change adds an option to group the path in the prom
metrics such that the matching route name is used instead
of the request uri path.
Note, this commit also alters the histogram fields by creating a
separate entry for method instead of prepending to the path.