Remove go module replace #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
=======================================
Coverage 43.88% 43.88%
=======================================
Files 6 6
Lines 319 319
=======================================
Hits 140 140
Misses 176 176
Partials 3 3 ☔ View full report in Codecov by Sentry. |
achichen
commented
Dec 27, 2023
| @@ -2,11 +2,6 @@ module github.com/carousell/Orion | |||
|
|
|||
| go 1.17 | |||
|
|
|||
| replace ( | |||
| git.apache.org/thrift.git => github.com/apache/thrift v0.12.0 | |||
There was a problem hiding this comment.
As git.apache.org/thrift.git is not even in direct or indirect dependency listed in this go.mod, it doesn't effectively affect the result of dependency resolution. The replace is no effect, can be safely removed.
achichen
commented
Dec 27, 2023
| @@ -2,11 +2,6 @@ module github.com/carousell/Orion | |||
|
|
|||
| go 1.17 | |||
|
|
|||
| replace ( | |||
| git.apache.org/thrift.git => github.com/apache/thrift v0.12.0 | |||
| github.com/openzipkin-contrib/zipkin-go-opentracing => github.com/openzipkin-contrib/zipkin-go-opentracing v0.3.5 | |||
There was a problem hiding this comment.
github.com/openzipkin-contrib/[email protected] is explicitly listed in this go.mod. no replace is needed to override the version
uneet77
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two go module replacement was added long time ago and no longer needed. See the line comment for the explanation