Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light Theme feature added #133

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Dark/Light Theme feature added #133

merged 3 commits into from
Sep 2, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Sep 2, 2023

Description:

Related issue (if applicable): refs #79

Added a Dark theme with the ability to toggle using icon at the top right hand side of the page.
image

The default mode is light, but this can be over-ridden if you set the APPRISE_DEFAULT_THEME to be dark instead.

This is entirely based on @STaRDoGG. I just made a few tweaks to some of the colors. I re-organized the inclusion of the CSS files as well (calling highlight.min.css last). in theory, this should be renamed to dark.css and another called light.css and some of the other duplication removed (especially the hacked entries in the materialize.min.css file)... But this is still a great start. Thank you so much @STaRDoGG for all your great work found here.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • Tests added

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.92%. Comparing base (e6700d1) to head (c16d9a9).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
apprise_api/core/middleware/theme.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   94.90%   94.92%   +0.01%     
==========================================
  Files          15       17       +2     
  Lines        1434     1457      +23     
==========================================
+ Hits         1361     1383      +22     
- Misses         73       74       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 42893d7 into master Sep 2, 2023
1 check passed
@caronc caronc deleted the nord-theme branch October 8, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants