Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted EOF control in telnet sync/async control chars #355

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

lorenzo-d-m
Copy link
Contributor

Description

PR related to issue #351.

The EOF sequence control has been added to telnet transport in PR #143 (Dmitriy's issue #142 ), however, after Matt's contribution, the EOF control can be removed from the _handle_control_chars method.

Also, connecting devices like Cisco PIX and some old ASA, that control raised the scrapli.exceptions.ScrapliConnectionNotOpened: server returned EOF, connection not opened exception. And it shouldn't.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested my update on a dozen devices, some of which inserted the EOF sequence in the middle of the stream, some at the end of the stream, and some did not. In all cases it worked well.

Checklist:

  • My code follows the style guidelines of this project (no GitHub actions complaints! run make lint before
    committing!)
  • I have commented my code, pydocstyle and darglint are happy, docstrings are in google docstring format, and all
    docstrings include a summary, args, returns and raises fields (even if N/A)
  • New and existing unit tests pass locally with my changes

@carlmontanari
Copy link
Owner

blah. I still need to fix whatever that mypy complaint is, so ignore that. LGTM, thanks a bunch for digging in and testing this up!

@carlmontanari carlmontanari merged commit 6dd94db into carlmontanari:main Oct 15, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants