Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate docker image push on release ci pipeline #4928

Closed
wants to merge 34 commits into from
Closed

Automate docker image push on release ci pipeline #4928

wants to merge 34 commits into from

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jan 9, 2025

Changes

  • catch dangerous tag clashing when bumping the wallet version
  • Rename tags on pipeline test branches to avoid clash
  • Avoid nix in the dockerhub pushing step

Issues

#4900

paolino and others added 3 commits January 9, 2025 11:46
@paolino
Change GENESIS_VERIFICATION_KEY
8dc0ba5
@paolino
Change mithril version
5492b60
@HeinrichApfelmus
Remove .#ci.tests.run.integration from nix flake
01424ac 
We no longer run integration tests by building a nix derivation — we run shell scripts from the `justfile` instead. This means that we no longer specify configuration variables for our integration tests in nix.
@paolino paolino marked this pull request as draft January 9, 2025 17:24
@paolino paolino self-assigned this Jan 9, 2025
@paolino paolino added Bug CI CI related labels Jan 9, 2025
@paolino paolino added this to the 2025Q1 milestone Jan 9, 2025
@paolino
Fix mithril download preprod instructions (#4922)
7790842 
- Update the mithril instructions to refresh the preprod state for the
E2E tests

#4918
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch from ada042c to 76da431 Compare January 9, 2025 17:42
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch from 76da431 to c3c3543 Compare January 9, 2025 18:00
Anviking and others added 11 commits January 9, 2025 18:30
@Anviking
Remove .#ci.tests.run.integration from nix flake (#4887)
ec8d583 
We no longer run integration tests by building a nix derivation — we run
shell scripts from the `justfile` instead. This means that we no longer
specify configuration variables for our integration tests in nix.
@abailly
Document usage of bech32 to convert account public key
8e3c256 
fix #4886
@paweljakubas
part 1
9a872b4
@paweljakubas
part 2
5c49807
@paweljakubas
part 3
95d02ad
@paweljakubas
part 4
b0e82f7
@paweljakubas
part 5
2872491
@paweljakubas
better hand plots
ce4840a
@paweljakubas
relocate multisig to docs' concepts
9ef7eee
@abailly
Document usage of bech32 to convert account public key (#4929)
cfa14dd 
fix #4886
@abailly
Multisig docs (#4924)
44d9aec 
<!--
Detail in a few bullet points the work accomplished in this PR.

Before you submit, don't forget to:

* Make sure the GitHub PR fields are correct:
   ✓ Set a good Title for your PR.
   ✓ Assign yourself to the PR.
   ✓ Assign one or more reviewer(s).
   ✓ Link to a Jira issue, and/or other GitHub issues or PRs.
   ✓ In the PR description delete any empty sections
     and all text commented in <!--, so that this text does not appear
     in merge commit messages.

* Don't waste reviewers' time:
   ✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped
through.

* Try to make your intent clear:
   ✓ Write a good Description that explains what this PR is meant to do.
   ✓ Jira will detect and link to this PR once created, but you can also
     link this PR in the description of the corresponding Jira ticket.
   ✓ Highlight what Testing you have done.
   ✓ Acknowledge any changes required to the Documentation.
-->

- [x] Multisig docs

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

fix #4875

<!-- Reference the Jira/GitHub issue that this PR relates to, and which
requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch 7 times, most recently from 835dbbd to b9e2321 Compare January 10, 2025 12:05
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch 3 times, most recently from 5cee18a to 09862db Compare January 10, 2025 17:57
@abailly abailly removed this from the 2025Q1 milestone Jan 12, 2025
abailly and others added 5 commits January 12, 2025 17:02
@abailly
Update README
bd40b2b 
* Remove or update badges that have become irrelevant following #4899
and #4908
* Move links to documentation at the beginning of the README
@paolino
Update README (#4938)
a5dc398 
* Remove or update badges that have become irrelevant following #4899
and #4908
* Move links to documentation at the beginning of the README

#4934
@paolino
abort when trying to rewrite the last cabal tag or release tag
28c3396
@paolino
Move ruby setup step inside windows artifacts group
da902c0
@paolino
Avoid running tests when testing the release
9f2f4fb
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch 2 times, most recently from 8c0f581 to e6a9202 Compare January 13, 2025 11:43
paolino added 12 commits January 13, 2025 12:05
@paolino
Separate test tag from nightly tag when pushing artifacts to the curr…
d173fd4 
…ent release tag
@paolino
Separate test tag from nightly tag when creating release tags
610f5b5
@paolino
Separate test tag from nightly tag when creating a release
71dcaa5
@paolino
Separate test tag from nightly tag when pushing swagger file to bump.sh
57281f9
@paolino
Fix release pipeline nightly naming
d874672
@paolino
Change bump daily repository name to nightly
a75091d
@paolino
Add new push-to-dockerhub script to replace the nix based one
38be56b
@paolino
Remove push to dockerhub step from main pipeline
a8b91b4
@paolino
Add push to dockerhub step for nightly and test tag
7d76894
@paolino
Replace old push to dockerhub step with a blocked one using the new s…
6be3477 
…cript
@paolino
Remove nix based push to dockerhub script
da789e8
@paolino
Remove concurrency from nightly/test and release step groups
051ab29
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch 2 times, most recently from 0377324 to b980b5d Compare January 13, 2025 13:05
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch from b980b5d to c1a71fa Compare January 13, 2025 13:17
@paolino
Copy link
Collaborator Author

paolino commented Jan 13, 2025

Duplicate of #4937

@paolino paolino marked this as a duplicate of #4937 Jan 13, 2025
@paolino paolino closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paolino paolino

Labels
Bug CI CI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paolino @abailly @HeinrichApfelmus @Anviking @paweljakubas