refactor configs to runtimes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| class BaseRuntime: | ||
| """Base configuration class that defines abstract methods (storage, run_config and executor) for subclasses.""" |
There was a problem hiding this comment.
"""Base runtime class
|
Values to move to
|
added 2 commits
January 24, 2022 21:47
jhamman
commented
Jan 25, 2022
Comment on lines
+6
to
+8
| 'intermediate': {'uri': '/tmp/flow-outputs/intermediates', 'storage_options': {}}, | ||
| 'results': {'uri': '/tmp/flow-outputs/results', 'storage_options': {}}, | ||
| 'temporary': {'uri': '/tmp/cmip6/temp/', 'storage_options': {}}, |
There was a problem hiding this comment.
See #76 for a follow up that will allow more reasonable defaults.
jhamman
commented
Jan 25, 2022
| 'results': {'uri': '/tmp/flow-outputs/results', 'storage_options': {}}, | ||
| 'temporary': {'uri': '/tmp/cmip6/temp/', 'storage_options': {}}, | ||
| }, | ||
| 'methods': {'bcsd': {}, 'gard': {}, 'maca': {}}, |
There was a problem hiding this comment.
@orianac - anything you think should be added here?
jhamman
commented
Jan 25, 2022
| 'storage.results.uri': '/tmp/results', | ||
| 'storage.temporary.uri': '/tmp/temporary', | ||
| } | ||
| ) |
There was a problem hiding this comment.
see #76 for a todo item here (this does not work as desired)
jhamman
commented
Jan 25, 2022
Comment on lines
+12
to
+13
| # cloud_runtime = CloudRuntime() | ||
| # assert isinstance(cloud_runtime, BaseRuntime) |
There was a problem hiding this comment.
It would be nice to find a way to mock this runtime. Added a todo in #76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.