Add support for testing with stdin #4819
Conversation
github-actions
bot
added
the
explorer
|
Based on #4812 |
| return {{.success = true}}; | ||
| } | ||
|
|
||
| // Does printing and returns expected results for stdin.carbon. |
There was a problem hiding this comment.
Had a minor hiccup reading this as starting a question ("Does printing <do this?>") rather than descriptive. Ambiguity might be removed by rephrasing to "Prints and returns ... "?
toolchain/driver/driver_env.h
Outdated
| // Standard output; stdout. | ||
| llvm::raw_pwrite_stream& output_stream; | ||
| llvm::raw_pwrite_stream* output_stream; | ||
| // Error output; stderr. | ||
| llvm::raw_pwrite_stream& error_stream; | ||
| llvm::raw_pwrite_stream* error_stream; |
There was a problem hiding this comment.
How come these became pointers?
There was a problem hiding this comment.
Style:
When storing an object's address as a non-owned member, prefer storing a pointer.
Note this is covered by #4812
| auto Run(std::FILE* input_stream, llvm::raw_ostream* output_stream, | ||
| llvm::raw_ostream* error_stream) -> ErrorOr<Success> { | ||
| CARBON_CHECK(input_stream && output_stream && error_stream); |
There was a problem hiding this comment.
If input_stream and output_stream have to be non-null, could they be passed by reference here instead of by pointer?
There was a problem hiding this comment.
Style:
If it is captured and must outlive the call expression itself, use a pointer and document that it must not be null (unless it is also optional).
Note this is covered by #4812
There was a problem hiding this comment.
Oh, wait I guess these can be references. I'll update #4812.
Did you notice that this is based on #4812? It looks like you're talking about changes from that PR's, instead of the "Add support for testing with stdin" commit. |
I didn't - not sure how multi-change reviews are done here in Carbon (LLVM has dabbled with them and various tools to help isolate the changes - I haven't had to interact with one of those stacked PRs I think, so never did figure out exactly how LLVM goes about it) |
In order to write language-server tests, we need some way to pass stdin input. This adds support for a split "// --- STDIN" which will be provided as a temp file for testing.
Note this does more stdin -> input_stream style renaming, this is just bugging me more since I know shadowing works but it can be subtle to read, particularly since I'm now making direct use of stdin in a handful of spots.