Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of https://docs.carbon-lang.dev/proposals/p2188.html #4802

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

zygoloid
Copy link
Contributor

Per https://kramdown.gettalong.org/syntax.html#html-blocks, kramdown doesn't render markdown inside HTML tags by default. Enable this globally to get results more similar to Github-Flavored Markdown.

…188.html

Per https://kramdown.gettalong.org/syntax.html#html-blocks, kramdown
doesn't render markdown inside HTML tags by default. Enable this
globally to get results more similar to Github-Flavored Markdown.
@github-actions github-actions bot requested a review from jonmeow January 15, 2025 02:28
@jonmeow
Copy link
Contributor

jonmeow commented Jan 15, 2025

As mentioned on chat, https://github.com/carbon-language/carbon-lang/blob/trunk/website/README.md has some instructions on how to test changes (prebuild.py and bundle exec jekyll). Can you please update here once you've had a chance to make sure the changes are what you expect?

@zygoloid zygoloid changed the title Attempt to fix rendering of https://docs.carbon-lang.dev/proposals/p2188.html Fix rendering of https://docs.carbon-lang.dev/proposals/p2188.html Jan 15, 2025
@zygoloid
Copy link
Contributor Author

It turns out that this kramdown setting is broken, and doesn't handle tables properly. Added a workaround in addition to enabling the setting.

@jonmeow jonmeow added this pull request to the merge queue Jan 15, 2025
Merged via the queue into carbon-language:trunk with commit a058f30 Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants