Add support for converting between integer types #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Just some drive-by thoughts -- this seems to really demonstrate that the SemIR formatted output is too brittle given the number of changes, all of which seemingly just due to 4 new impls appearing.
Also maybe a comment tweak suggested inline. I couldn't really find the tests of this logic due to all the churn.
| fn Convert[self: Self]() -> UInt(N) = "int.convert"; | ||
| } | ||
|
|
||
| // TODO: Allow as an implicit conversion if N > M. |
There was a problem hiding this comment.
I think this is right as-is: all values of uN fit in i(N+1), so it's OK for that to be implicit. The other comments could use >= instead of >, but that would only allow identity conversions which we already allow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a builtin
"int.convert"supporting unchecked conversions between different integer types. This performs a truncation, zero-extension, or sign-extension, depending on the widths of the operands and the signedness of the source type. Add explicitAssupport to the prelude. No implicit conversions are supported yet as we don't have a way to express the constraint that we can only implicitly convert to wider types.