Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower global variables #4228

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Lower global variables #4228

merged 2 commits into from
Aug 19, 2024

Conversation

hamphet
Copy link
Contributor

@hamphet hamphet commented Aug 19, 2024

No description provided.

@github-actions github-actions bot requested a review from zygoloid August 19, 2024 01:19
jonmeow
jonmeow reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The tests look good to me. I have a suggestion on insts calls, but that's the main thing.

toolchain/lower/file_context.h Outdated Show resolved Hide resolved
toolchain/lower/file_context.cpp Outdated Show resolved Hide resolved
toolchain/lower/file_context.cpp Show resolved Hide resolved
toolchain/lower/file_context.cpp Outdated Show resolved Hide resolved
toolchain/lower/file_context.cpp Outdated Show resolved Hide resolved
@jonmeow jonmeow enabled auto-merge August 19, 2024 22:35
jonmeow
jonmeow approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes all look great!

@jonmeow jonmeow added this pull request to the merge queue Aug 19, 2024
Merged via the queue into carbon-language:trunk with commit 61e87c3 Aug 19, 2024
7 checks passed
@hamphet hamphet deleted the lower-globals branch August 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamphet @jonmeow