Modify toolchain/autoupdate_testdata.py to use scripts/scripts_utils.py #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
approved these changes
Aug 19, 2024
|
Is the |
hamphet
force-pushed
the
autoupdate-bazelisk
branch
2 times, most recently
from
ce45a9e to
9b464cb
Compare
|
Thanks for the suggestions, looks much better! |
jonmeow
reviewed
Aug 19, 2024
hamphet
force-pushed
the
autoupdate-bazelisk
branch
from
9b464cb to
3c8d410
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
I think `paths.parents[2]` is easier to read than `path.parent.parent.parent`, just applying uniformly. I'd noticed this while looking at #4227 Also remove a couple `resolve()` calls that shouldn't be necessary since `__file__` is absolute (elsewhere in the same files, `resolve()` is used to resolve potentially relative paths)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
toolchain/autoupdate_testdata.pyscript assumes the correct bazel version is already installed. This change usesscripts/scripts_utils.pyto fallback tobazelisk.