Refactor ReturnTypeInfo and InitRepr.
#4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
approved these changes
Jul 25, 2024
toolchain/sem_ir/type_info.h
Outdated
| }; | ||
|
|
||
| // Returns information about the initializing representation to use for a type. | ||
| auto GetInitRepr(const File& file, TypeId type_id) -> InitRepr; |
There was a problem hiding this comment.
Should this be InitRepr::ForType similar to below? (plus, member functions for factories makes sense to me)
toolchain/sem_ir/function.h
Outdated
Comment on lines
78
to
82
| auto GetReturnTypeInfo(const File& file, | ||
| SpecificId specific_id = SpecificId::Invalid) const | ||
| -> ReturnTypeInfo { | ||
| return ReturnTypeInfo::ForType(file, | ||
| GetDeclaredReturnType(file, specific_id)); |
There was a problem hiding this comment.
FWIW, if it worked, maybe ReturnTypeInfo::ForFunction instead?
brymer-meneses
pushed a commit
to brymer-meneses/carbon-lang
that referenced
this pull request
Aug 15, 2024
Rename `ReturnInfo` to `ReturnTypeInfo`. Move it and `InitRepr` into `type_info.h` alongside `ValueRepr`. Replace `ReturnSlot` with `InitRepr`, and extend `InitRepr` to be able to represent the incomplete-type case instead of CHECK-failing. Remove `has_return_slot` from `InitRepr` and instead only provide that as part of `ReturnTypeInfo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
ReturnInfotoReturnTypeInfo. Move it andInitReprintotype_info.halongsideValueRepr. ReplaceReturnSlotwithInitRepr, and extendInitReprto be able to represent the incomplete-type case instead of CHECK-failing. Removehas_return_slotfromInitReprand instead only provide that as part ofReturnTypeInfo.