fix: use explicit spacing versus browser default (#939)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · Apr 19, 2021 · 82c7693 · 82c7693
1 parent 636d539
commit 82c7693
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 5 deletions.
diff --git a/src/__tests__/scss/__snapshots__/SCSS.spec.js.snap b/src/__tests__/scss/__snapshots__/SCSS.spec.js.snap
@@ -2668,6 +2668,8 @@ body {
   font-weight: 400;
   line-height: 1.34;
   letter-spacing: 0.32px;
+  margin-top: 0.75rem;
+  margin-bottom: 0.75rem;
 }
 
 .security--card__body {
@@ -5892,6 +5894,7 @@ a.bx--overflow-menu-options__btn::before {
   line-height: 1.4;
   letter-spacing: 0;
   display: block;
+  margin-top: 1rem;
   margin-bottom: 0.75rem;
 }
 
@@ -9240,6 +9243,7 @@ li.bx--accordion__item--disabled:last-of-type {
   letter-spacing: 0.32px;
   font-weight: 600;
   display: flex;
+  margin-top: 0.5rem;
   margin-bottom: 1rem;
   justify-content: space-between;
 }
@@ -9647,6 +9651,8 @@ li.bx--accordion__item--disabled:last-of-type {
   font-weight: 400;
   line-height: 1.29;
   letter-spacing: 0.16px;
+  margin-top: 0.75rem;
+  margin-bottom: 0.75rem;
 }
 
 .security--filter-panel__search {
@@ -16974,6 +16980,8 @@ li.bx--accordion__item--disabled:last-of-type {
   font-weight: 400;
   line-height: 1.34;
   letter-spacing: 0.32px;
+  margin-top: 0.5rem;
+  margin-bottom: 0.5rem;
 }
 
 .security--tag-wall > .security--tag--interactive {
@@ -17982,6 +17990,7 @@ li.bx--accordion__item--disabled:last-of-type {
   letter-spacing: 0;
   padding-right: 1.5rem;
   margin-top: 0;
+  margin-bottom: 1.5rem;
 }
 
 .security--tearsheet__main__content {

diff --git a/src/components/Card/_mixins.scss b/src/components/Card/_mixins.scss
@@ -1,7 +1,7 @@
 ////
 /// Card mixins.
 /// @group card
-/// @copyright IBM Security 2019
+/// @copyright IBM Security 2019 - 2021
 ////
 
 @import '@carbon/layout/scss/mini-unit';
@@ -70,7 +70,11 @@ $card__name: card;
     }
 
     &__tag {
+      $card__tag__spacing: $carbon--spacing-04;
+
       @include carbon--type-style($name: caption-01);
+      margin-top: $card__tag__spacing;
+      margin-bottom: $card__tag__spacing;
     }
   }
 

diff --git a/src/components/FilterPanel/LEGACY_FilterPanel/FilterCategory/_index.scss b/src/components/FilterPanel/LEGACY_FilterPanel/FilterCategory/_index.scss
@@ -1,7 +1,7 @@
 ////
 /// Filter category styles.
 /// @group filter-panel
-/// @copyright IBM Security 2019
+/// @copyright IBM Security 2019 - 2021
 ////
 
 @import '@carbon/layout/scss/mini-unit';
@@ -28,6 +28,7 @@
     @include carbon--font-weight($weight: semibold);
 
     display: flex;
+    margin-top: $carbon--spacing-03;
     margin-bottom: $carbon--spacing-05;
     justify-content: space-between;
   }

diff --git a/src/components/FilterPanel/_index.scss b/src/components/FilterPanel/_index.scss
@@ -1,7 +1,7 @@
 ////
 /// Filter panel styles.
 /// @group filter-panel
-/// @copyright IBM Security 2020
+/// @copyright IBM Security 2020 - 2021
 ////
 
 @import '@carbon/layout/scss/spacing';
@@ -21,7 +21,12 @@
 
 @include security--component($name: filter-panel) {
   &__title {
+    $filter-panel__spacing: $carbon--spacing-04;
+
     @include carbon--type-style($name: body-short-01);
+
+    margin-top: $filter-panel__spacing;
+    margin-bottom: $filter-panel__spacing;
   }
 
   &__search {

diff --git a/src/components/PanelV2/_mixins.scss b/src/components/PanelV2/_mixins.scss
@@ -1,7 +1,7 @@
 ////
 /// Panel mixins.
 /// @group panel
-/// @copyright IBM Security 2019 - 2020
+/// @copyright IBM Security 2019 - 2021
 ////
 
 @import '@carbon/layout/scss/mini-unit';
@@ -118,6 +118,7 @@
       @include carbon--type-style($name: productive-heading-03);
 
       display: block;
+      margin-top: $carbon--spacing-05;
       margin-bottom: $carbon--spacing-04;
     }
 

diff --git a/src/components/TagWall/_mixins.scss b/src/components/TagWall/_mixins.scss
@@ -1,7 +1,7 @@
 ////
 /// Tag wall mixins.
 /// @group tag-wall
-/// @copyright IBM Security 2019
+/// @copyright IBM Security 2019 - 2021
 ////
 
 @import '@carbon/type/scss/index';
@@ -10,7 +10,11 @@
 
 @mixin tag-wall {
   &__label {
+    $tag-wall__spacing: $carbon--spacing-03;
+
     @include carbon--type-style($name: caption-01);
+    margin-top: $tag-wall__spacing;
+    margin-bottom: $tag-wall__spacing;
   }
 
   > #{$tag--interactive__namespace} {

diff --git a/src/components/Tearsheet/_mixins.scss b/src/components/Tearsheet/_mixins.scss
@@ -197,6 +197,7 @@ $tearsheet__layer: z(
       @include carbon--type-style($name: productive-heading-04);
       padding-right: $tearsheet__spacing__padding;
       margin-top: 0;
+      margin-bottom: $tearsheet__spacing__padding;
     }
 
     &__content {