Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show TC sample text in correct font #1392

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: show TC sample text in correct font #1392

wants to merge 3 commits into from

Conversation

skylee03
Copy link

@skylee03 skylee03 commented Dec 7, 2024

The sample text for Traditional Chinese is not shown in IBM Plex Sans TC but a fallback font as detailed in the issue:

Changelog

Changed

  • Changed the class name bx--type-mono with bx--type-chinese.

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-language-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:08pm

@skylee03 skylee03 marked this pull request as ready for review December 7, 2024 16:50
@skylee03 skylee03 requested a review from a team as a code owner December 7, 2024 16:50
@skylee03 skylee03 requested review from Palke and removed request for a team December 7, 2024 16:50
@Palke Palke requested review from Dan-Pastrolin-IBM and removed request for Palke December 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan-Pastrolin-IBM Dan-Pastrolin-IBM Awaiting requested review from Dan-Pastrolin-IBM

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Sample Font for Traditional Chinese
1 participant
@skylee03