Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Sample Font for Traditional Chinese #1391

Open
skylee03 opened this issue Dec 7, 2024 · 0 comments · May be fixed by #1392
Open

Incorrect Sample Font for Traditional Chinese #1391

skylee03 opened this issue Dec 7, 2024 · 0 comments · May be fixed by #1392
Labels
status: needs triage 🕵️‍♀️

Comments

@skylee03
Copy link

skylee03 commented Dec 7, 2024 •
edited
Loading

The sample text for Traditional Chinese is not shown in IBM Plex Sans TC but a fallback font.
This is probably due to a typo in the following PR:

While .#{$prefix}--type-chinese was added to the SCSS file, the class name for the sample text was set to ${prefix}--type-mono.

Replace the class name bx--type-mono with bx--type-chinese could fix this issue.

  • Before
    image

  • After
    image
@skylee03 skylee03 linked a pull request Dec 7, 2024 that will close this issue
Open
@skylee03 skylee03 changed the title Incorrect Sample Font for Traditional Chinese in IBM Design Language Incorrect Sample Font for Traditional Chinese Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage 🕵️‍♀️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show TC sample text in correct font skylee03/design-language-website
1 participant
@skylee03