Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(carbon-react): update Downshift to v6 #6918

Closed
wants to merge 4 commits into from
Closed

feat(carbon-react): update Downshift to v6 #6918

wants to merge 4 commits into from

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Sep 25, 2020

Upgrades us to latest Downshift. Prep work for swapping our useSelect in Multiselect to useMultipleselection hook and maybe Combobox to useCombobox

Testing / Reviewing

Check the Downshift components are working as intended:

  • MultiSelect
  • Combobox
  • Dropdown

@dakahn dakahn requested a review from a team as a code owner September 25, 2020 20:32
@netlify
Copy link

netlify bot commented Sep 25, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit c95a53d

https://deploy-preview-6918--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 25, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit c95a53d

https://deploy-preview-6918--carbon-components-react.netlify.app

joshblack
joshblack approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there aren't really any breaking changes with this update outside of TS types, right?

@joshblack
Copy link
Contributor

bump @aledavila when you have a sec to review today

@joshblack
Copy link
Contributor

One quick note, commit type should be feat for the merge commit so this will end up triggering a minor release 👍

aledavila
aledavila approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good

@aledavila
Copy link
Contributor

waiting on @dakahn to update commit

@dakahn dakahn changed the title chore(carbon-react): update Downshift to v6 feat(carbon-react): update Downshift to v6 Sep 28, 2020
@dakahn
Copy link
Contributor Author

dakahn commented Sep 29, 2020

We've got some broken tests i'm clearing up now @aledavila @joshblack

@dakahn
Copy link
Contributor Author

dakahn commented Sep 30, 2020

I'm going to close this up and get the upgrade in with the work i'm doing on #6102 👍

@dakahn dakahn closed this Sep 30, 2020
@emyarod emyarod mentioned this pull request Oct 1, 2020
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakahn @joshblack @aledavila