Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Loading): wc parity issues #18343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amal-k-joy
Copy link

@amal-k-joy amal-k-joy commented Jan 14, 2025

Closes #17925

Fixing parities in Loading component between react and webcomponent. Below props in webcomponents was not matching with what we have in react. So added new props and deprecating the respective ones to match with React

                      React                 Webcomponents

                      active	  ==>       inactive
		      description ==>	    assistiveText
		      small	 ==>	    type	

Changelog

Changed

  • packages/web-components/src/components/loading/loading-icon.ts
  • packages/web-components/src/components/loading/loading.ts
  • packages/web-components/src/components/loading/loading.stories.ts
  • packages/web-components/src/components/loading/loading.scss

Testing / Reviewing

Can be verified in storybook controls

@amal-k-joy amal-k-joy requested a review from a team as a code owner January 14, 2025 11:18
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 59c9648
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67864a4b2bb48200082aba32
😎 Deploy Preview https://deploy-preview-18343--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 38cfa32
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6786481d88ef1c00083fb68a
😎 Deploy Preview https://deploy-preview-18343--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 59c9648
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67864a4b3c45d10008cac8fe
😎 Deploy Preview https://deploy-preview-18343--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Loading
1 participant