Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sb): normalize SB deps versions #18321

Merged

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Jan 9, 2025

This syncs Storybook and addon versions in React and Web component packages. This should resolve the unnecessarily long version mismatch warning:

image

Changelog

Changed

  • update Storybook and Storybook addons to v8.4.7

@kennylam kennylam requested a review from a team as a code owner January 9, 2025 18:12
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 21bcd00
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6780119e5cf2fa0008f7874e
😎 Deploy Preview https://deploy-preview-18321--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 21bcd00
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6780119e906eee0008f687fa
😎 Deploy Preview https://deploy-preview-18321--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not seeing that massive output locally anymore with this change

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 21bcd00
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6780119efef75a000825fa14
😎 Deploy Preview https://deploy-preview-18321--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for cleaning this up

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🙏

@tay1orjones tay1orjones enabled auto-merge January 9, 2025 20:50
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (7557e1d) to head (21bcd00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18321   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4690     4690           
=======================================
  Hits        12150    12150           
+ Misses       2121     2120    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tay1orjones tay1orjones added this pull request to the merge queue Jan 9, 2025
Merged via the queue into carbon-design-system:main with commit 9840477 Jan 9, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants