-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu and Friends workstream #15398
Menu and Friends workstream #15398
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking awesome! Just a few questions from my end.
Also I think it would be a good idea to mark all new positioning/width/alignment props as experimental because eventually we'll want to flip out parts of the implementation to use floating-ui.
packages/react/src/components/ComboButton/ComboButton.stories.js
Outdated
Show resolved
Hide resolved
@guidari this looks good to me, ready to merge after removing the testing stories 👍 |
722b329
Closes carbon-design-system/carbon-website#3790
Closes carbon-design-system/carbon-website#3792
Closes carbon-design-system/carbon-website#3791
To see the specs go to this issue.
Note: the changes were made in the
OverflowMenu
with feature flagChangelog
New
ComboButton
,MenuButton
andOverflowMenu
componentsMenu
componentComboButton
,MenuButton
andOverflowMenu
componentsmenuAlignment
propTesting / Reviewing for
ComboButton
,MenuButton
andOverflowMenu
DO NOT MERGE UNTIL PLAYGROUND TEST IS REMOVED
ComboButton