Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu and Friends workstream #15398

Merged
merged 48 commits into from
Feb 5, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Dec 15, 2023

Closes carbon-design-system/carbon-website#3790
Closes carbon-design-system/carbon-website#3792
Closes carbon-design-system/carbon-website#3791

To see the specs go to this issue.

Note: the changes were made in the OverflowMenu with feature flag

Changelog

New

  • The ellipsis to the Primary button
  • New prop in the ComboButton, MenuButton and OverflowMenu components
  • Two new props in the Menu component
  • New docs for ComboButton, MenuButton and OverflowMenu components
  • Test for new menuAlignment prop
  • Added new stories called "Component Menu Alignment" for the Menu and friends
  • Added new shadow styling for top alignment

Testing / Reviewing for ComboButton, MenuButton and OverflowMenu

  • Test the ellipsis in the Primary Button and Menu
  • Test the 3 different components
  • Test the different alignments in the playground with different postions of the Primary Button

DO NOT MERGE UNTIL PLAYGROUND TEST IS REMOVED

  • Remove Playground test alignment in ComboButton

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8a8d157
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65c0f7fae711ee00080d1982
😎 Deploy Preview https://deploy-preview-15398--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking awesome! Just a few questions from my end.

Also I think it would be a good idea to mark all new positioning/width/alignment props as experimental because eventually we'll want to flip out parts of the implementation to use floating-ui.

packages/react/src/components/ComboButton/index.js Outdated Show resolved Hide resolved
packages/react/src/components/Menu/Menu.tsx Outdated Show resolved Hide resolved
@tay1orjones
Copy link
Member

@guidari this looks good to me, ready to merge after removing the testing stories 👍

@guidari guidari added this pull request to the merge queue Feb 5, 2024
Merged via the queue into carbon-design-system:main with commit 722b329 Feb 5, 2024
20 checks passed
@guidari guidari deleted the 3790-combobutton-2 branch February 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflowmenu: dev/style updates Menubutton: dev/style updates ComboButton: dev/style updates
6 participants