-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LTS notification - v10 storybook #14860
Add LTS notification - v10 storybook #14860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think it's fine if this doesn't show up on the uishell stories for now, this will hit the vast majority of users being on every other component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, the link color is wrong for a black background, so may want to get a designer to take a look. Could be easiest to match what we have on the website banner style-wise?
Could be something like this, to match the website style. |
Closes #14765
I've tested each default story, and they all appear to be working well. However, when it comes to the UIShell, there's an issue with the sticky/fixed header. I'm considering the best course of action, which might involve excluding the UIShell from the LTS notification, to prevent any additional problems when working with that particular story.
Changelog
New
Testing / Reviewing
OBS: The message it is just an example, we are still selecting the best one.