Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LTS notification - v10 storybook #14860

Merged
merged 10 commits into from
Oct 19, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 10, 2023

Closes #14765

I've tested each default story, and they all appear to be working well. However, when it comes to the UIShell, there's an issue with the sticky/fixed header. I'm considering the best course of action, which might involve excluding the UIShell from the LTS notification, to prevent any additional problems when working with that particular story.

Changelog

New

  • Added LTS notification

Testing / Reviewing

  • Check if the design looks good
  • Check if the components looks good

OBS: The message it is just an example, we are still selecting the best one.

@guidari guidari requested a review from a team October 10, 2023 20:06
@guidari guidari requested a review from a team as a code owner October 10, 2023 20:06
@guidari guidari requested review from aubrey-oneal, alisonjoseph, tw15egan and sstrubberg and removed request for a team October 10, 2023 20:06
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it's fine if this doesn't show up on the uishell stories for now, this will hit the vast majority of users being on every other component.

packages/react/.storybook/Container.js Outdated Show resolved Hide resolved
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, the link color is wrong for a black background, so may want to get a designer to take a look. Could be easiest to match what we have on the website banner style-wise?

@guidari
Copy link
Contributor Author

guidari commented Oct 13, 2023

Overall looks good, the link color is wrong for a black background, so may want to get a designer to take a look. Could be easiest to match what we have on the website banner style-wise?

Could be something like this, to match the website style.

Screenshot 2023-10-13 at 10 13 14

@guidari guidari enabled auto-merge (squash) October 17, 2023 16:06
@guidari guidari disabled auto-merge October 17, 2023 16:06
@guidari guidari requested a review from alisonjoseph October 17, 2023 16:06
@guidari guidari enabled auto-merge (squash) October 19, 2023 11:26
@guidari guidari merged commit 83a6bbb into carbon-design-system:v10 Oct 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants