Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add non-interactive icon and search guidance to contained list #4429

Merged

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Jan 13, 2025

Closes #3612
Closes #3615

This PR updates the Contained list component usage and style tab documentation with additions of non-interactive icons and search/filter guidance.


Changelog

New

  • Non-interactive icon written content and images
  • Search/filter written content and images

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Jan 23, 2025 5:10pm

@laurenmrice laurenmrice changed the title docs: add decorative icon and search guidance to contained list docs: add non-interactive icon and search guidance to contained list Jan 14, 2025
@laurenmrice laurenmrice requested a review from thyhmdo January 14, 2025 14:58
@laurenmrice laurenmrice marked this pull request as ready for review January 14, 2025 14:59
@laurenmrice laurenmrice requested review from a team as code owners January 14, 2025 14:59
@laurenmrice
Copy link
Member Author

For some reason the vercel deployment keeps failing, could a dev redeploy it for me? Thanks!

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small markdown fix, otherwise LGTM!

src/pages/components/contained-list/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/contained-list/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/contained-list/style.mdx Outdated Show resolved Hide resolved
src/pages/components/contained-list/style.mdx Outdated Show resolved Hide resolved
src/pages/components/contained-list/style.mdx Outdated Show resolved Hide resolved
src/pages/components/contained-list/style.mdx Outdated Show resolved Hide resolved
@laurenmrice
Copy link
Member Author

@kennylam Would you mind redeploying this so it can merge? I don't have permissions. Thanks!

@alisonjoseph alisonjoseph disabled auto-merge January 24, 2025 14:13
@alisonjoseph alisonjoseph merged commit 88285c4 into carbon-design-system:main Jan 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contained list: Non-interactive Icons 🌳 Contained list: Filterable Search 🌳
4 participants