feat: add card layout to a11y status component #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Taylor Jones <[email protected]>
|
Looks great. The only thing I'd change is the heading size. It looks nice with the H2 but they look bigger than the H3 here. Can we change the heading to 14px size? With H2 
With H3 
Would like to change to this, 14px, that's probably body text? 
|
|
Just pushed an update for those ResourceCards to use 
|
thyhmdo
added
status: visual review 🔍
status: ready for review 👀
and removed
status: ready for review 👀
status: visual review 🔍
labels
guidari
approved these changes
Feb 14, 2024
tay1orjones
reviewed
Feb 14, 2024
Co-authored-by: Taylor Jones <[email protected]>
…bon-website into a11y-status-usage-cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3847
Closes #3850
Add Ally status to Usage component pages
Changelog
cardortableviewReview
Component Usage pages
https://carbondesignsystem-7uo0s6vpp-carbon-design-system.vercel.app/components/breadcrumb/usage/
Also ensure that all previous a11y status work (on overview page and component a11y pages) is still working correctly.