docs(contribution): added carbon tutorial #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tay1orjones
approved these changes
Nov 9, 2023
laurenmrice
requested changes
Nov 10, 2023
There was a problem hiding this comment.
The gif in the cards illustration is distorted. But it looks like its wrong and distorted in the Tutorial page itself 😔
I have made an issue in the carbon-website repo to fix all of the buggy demo/images that are shown in the React tutorial, because most of them are not scaling right. So that can be tackled separately.
andreancardona
approved these changes
Dec 5, 2023
laurenmrice
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Approving! But noting that the card for "Carbon Tutorial" gif/image needs to be fixed once the React tutorial bug issue I created in the carbon-website repo is resolved. (unless this automatically gets updated on its own).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the React Testing Library contribution and added the React Tutorial contribution.
Cycling out the old and adding the new.
Testing
Confirm that the Tutorial is the first listed on the Contribution Gallery on the following page.
https://carbondesignsystem-git-fork-sstrubb-09d053-carbon-design-system.vercel.app/contributing/get-started/#contribution-gallery